[wine-tools] patches: Add a "Staging" status.

Austin English austinenglish at gmail.com
Fri Jun 5 11:35:19 CDT 2015


On Fri, Jun 5, 2015 at 11:30 AM, Michael Stefaniuc <mstefani at redhat.de> wrote:
> ---
>  patches/expire      | 1 +
>  patches/patches.css | 1 +
>  patches/update      | 2 ++
>  3 files changed, 4 insertions(+)
>
> diff --git a/patches/expire b/patches/expire
> index f143ab1..3cf75e6 100755
> --- a/patches/expire
> +++ b/patches/expire
> @@ -37,6 +37,7 @@ my %status_expiry =
>   "split"      => 7,
>   "depend"     => 7,
>   "sequence"   => 7,
> + "staging"    => 30,
>   "superseded" => 1,
>   "testcase"   => 7,
>   "testfail"   => 7,
> diff --git a/patches/patches.css b/patches/patches.css
> index 745ec75..5746057 100644
> --- a/patches/patches.css
> +++ b/patches/patches.css
> @@ -154,6 +154,7 @@ tr.odd { background-color: #f8e8e8; }
>  .sequence,   .sequence :link,   .sequence :visited   { color: #e08000; }
>  .deferred,   .deferred :link,   .deferred :visited   { color: #e08000; }
>  .testcase,   .testcase :link,   .testcase :visited   { color: #e08000; }
> +.staging,    .staging :link,    .staging :visited    { color: #e08000; }
>  .other,      .other :link,      .other :visited      { color: #e08000; }
>  .applyfail,  .applyfail :link,  .applyfail :visited  { color: red; }
>  .buildfail,  .buildfail :link,  .buildfail :visited  { color: red; }
> diff --git a/patches/update b/patches/update
> index 4ccc910..335af0b 100755
> --- a/patches/update
> +++ b/patches/update
> @@ -40,6 +40,7 @@ my %status_descr =
>   "depend"     => "Dependency",
>   "superseded" => "Superseded",
>   "sequence"   => "Bad sequence",
> + "staging"    => "Staging",
>   "testcase"   => "Needs tests",
>   "testfail"   => "Test failure",
>  );
> @@ -57,6 +58,7 @@ my @legend =
>                   "<li>Someone else fixed the problem already.</li></ul>" ],
>   [ "testcase",   "<ul><li>You need to write some test cases demonstrating that the patch is correct.</li></ul>" ],
>   [ "deferred",   "<ul><li>The patch is deferred because of code freeze for an upcoming release. Either resend after the release, make the patch less intrusive, or make a convincing argument that it needs to be included in the release.</li></ul>" ],
> + [ "staging",    "<ul><li>The patch needs more work or wider testing. Please get it in over Wine Staging.</li></ul>" ],
>   [ "other",      "<ul><li>The patch belongs to another WineHQ project (website, appdb, etc.) and will be applied by the respective maintainer.</li></ul>" ],
>   [ "applyfail",  "<ul><li>The patch got mangled in transit.</li>" .
>                   "<li>It's not relative to the latest git.</li>" .
> --
> 2.4.2

I'm not sure we want to encourage wine-stating from Upstream (I'm not
convinced either way), but in any case, the grammar seems wrong to me
as a native speaker, how about:
"The patch needs more work or wider testing. Please try to get into
Wine-Staging."

or something similar?

-- 
-Austin



More information about the wine-devel mailing list