[3/3] advapi32/tests: Add preliminary event tracing tests.

Nikolay Sivov bunglehead at gmail.com
Tue Jun 9 00:36:16 CDT 2015


On 09.06.2015 4:20, Ztirfe Elgnid wrote:
> On 06/08/2015 01:54 AM, Nikolay Sivov wrote:
>> On 08.06.2015 6:56, Zebediah Figura wrote:
>>> +    /* test ERROR_DISK_FULL */
>>> +    properties->MaximumFileSize = 1000000000000; /* 1 EB */
>>> +    SetLastError(0xdeadbeef);
>>> +    ret = StartTraceA(&handle, sessionname, properties);
>>> +    todo_wine
>>> +    {
>>> +    ok(ret != ERROR_SUCCESS, "Expected failure\n");
>>> +    ok(GetLastError() == ERROR_DISK_FULL, "Expected ERROR_DISK_FULL, got %d\n", GetLastError());
>>> +    }
>>> +    properties->MaximumFileSize = 0;
>> Patches look fine to me, but I have to ask - is it possible that this
>> test will actually try to write that much?
> That's... actually probably a reasonable fear. I'll remove that line.
>

Also I guess you noticed, but just in case, testbot reported some 
failures with your test patch, you should have got an email with a log. 
Note that failures differ for different windows versions.



More information about the wine-devel mailing list