gdiplus: Implement trivial case of GdipCreateRegionRgnData for empty and infinite regions
sebastian at fds-team.de
Tue Jun 9 02:18:39 CDT 2015
On 09.06.2015 09:02, Nikolay Sivov wrote:
> On 09.06.2015 9:47, Sebastian Lackner wrote:
>> On 09.06.2015 08:34, Nikolay Sivov wrote:
>>> On 09.06.2015 9:24, Dmitry Timoshkov wrote:
>>>> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>>>>> First bits for https://bugs.winehq.org/show_bug.cgi?id=34843
>>>> What is the reason of reimplementing it when wine-staging already
>>>> includes full implementation with tests?
>>> The reason is simple, to have this actually implemented in wine. The fact that it's included somewhere doesn't help with that.
>>> When I asked you yesterday to submit it, that was your response https://bugs.winehq.org/show_bug.cgi?id=34843#c12.
>> Hello Nikolay,
>> I can only repeat what I already tried to tell you several times on IRC. With your current approach, taking existing patches, rewriting them in your own style, and then submitting them upstream, you are not really helping to solve existing problems with patch acceptance.
> I'm not trying to solve anything, we got a bug, patch was attached, no interest to work on it from its author, and no attempts to send/improve it from you guys by the way.
"I am not planning to resend the same version over and over again" doesn't mean that there is no interest from the author. I'm pretty sure that Dmitry would be interested in useful feedback or just getting his patch accepted.
Besides that I'm always surprised how you try to blame Wine Staging for not doing certain things. Wine Staging is a community project, you can also participate by suggesting improvements for patches or helping to get them upstream while keeping the original author.
>> Are you planning to rewrite all Staging patches, and send them upstream on your own?
> Of course not, I don't think we need them all.
>> If there is nothing wrong with Dmitrys patch you could easily submit it as-is, and give proper attribution.
> I'm not sending something that even original author doesn't care about.
See above, not resending the same version over and over again has nothing to do with not caring about it. It has something to do with specific contributions not taken serious enough.
>> If there is something wrong, you could inform him about the issues you found, so he can improve it. The reason why he doesn't want to resend is most likely
>> that the last few attempts were without any useful comments.
> I think Dmitry knows how patch submission process works.
You mean he is long enough involved in Wine development to know that some thing are just broken by design?
More information about the wine-devel