[wine-tools] patches: Add a "Staging" status.

Michael Stefaniuc mstefani at redhat.com
Tue Jun 9 05:31:07 CDT 2015

Hash: SHA1

On 06/08/2015 08:22 AM, Alexandre Julliard wrote:
> Austin English <austinenglish at gmail.com> writes:
>> I'm not sure we want to encourage wine-stating from Upstream (I'm
>> not convinced either way), but in any case, the grammar seems
>> wrong to me as a native speaker, how about: "The patch needs more
>> work or wider testing. Please try to get into Wine-Staging."
> I'm not going to use such a status, because I don't think getting 
> patches into staging is going to make them more likely to be
> accepted.
The UTF-7 and JobObject patches are prime examples of patches that
successfully took the staging route. Before those had status
"New - Patch not even looked at yet, there's *no* hope..."

> On the contrary, if the iterations of the patch take place
> somewhere that I don't see, it will make it harder for me to assess
> the developer's ability (aka AJ rank), which is an essential part
> of the process. Particularly if you want to move on to more
> complicated things where I can't check every detail, it's essential
> to first earn my trust, or the trust of other veteran devs, and
> this has to happen right here.
I should have been less terse hoping that the intend of the Staging
status is obvious...

I meant Staging for those patches where the AJ rank is known to be
sub-par for the task at hand. When the patches rot in New status and
the usual reviewers just shrug their shoulders with an "I see nothing
obviously wrong". And Staging picks those patches up. Basically I was
just trying to formalize the de facto process.

> I see the value of wine-staging in making patches more readily
> available to users, and I understand that the process of getting
> patches committed
I see it also as an useful development tool similar to the Regression
page but just for patches in bugzilla.

> can be frustrating. But I don't think splitting the developers
> community is the answer.

Version: GnuPG v2.0.14 (GNU/Linux)


More information about the wine-devel mailing list