ntdll: Improve stub of NtQueryEaFile.
sebastian at fds-team.de
Wed Jun 10 03:00:04 CDT 2015
On 10.06.2015 09:15, Alexandre Julliard wrote:
> Sebastian Lackner <sebastian at fds-team.de> writes:
>> Based on a patch by Qian Hong.
> I don't remember seeing any such patch. Qian is around, so I expect he
> should be able to submit his own work himself. Then you can submit your
> part as your own separate patch.
> It's not a big deal for a small patch like this, but I don't want you to
> get into the habit of submitting patches containing bits and pieces of
> other people's work. I expect developers to stand behind their work, and
> take responsibility for getting their patches committed. Helping them is
> good, but taking over their work isn't.
I understand your concerns, but from my understanding you also don't want
patches which for example temporarily introduce bugs, just to fix them
Qian Hongs original patch is available here:
The original version lacked proper parameter checking, and also didn't clear
the full buffer. To be honest, there isn't really much left from the original
version, but I still think its fair to give attribution to Qian. We were working
together on fixing various msys2 bugs, and this was one of them.
Do you have a better suggestion how to deal with such situations in the future?
In case of active contributors I can ask them to fix the most critical bugs of
course, and afterwards put my patch on top of it. But what about inactive
contributors? What about series of patches where the initial idea turned out to
be wrong, and it was later fixed by a different contributor on top of the
I think it would be really nice to define a bit more exactly what is allowed/
preferred here and what not, especially when thinking about long standing
problems like the inclusion of the Pulseaudio patchset.
More information about the wine-devel