ntdll: Improve stub of NtQueryEaFile.

Alexandre Julliard julliard at winehq.org
Thu Jun 11 00:27:16 CDT 2015


Sebastian Lackner <sebastian at fds-team.de> writes:

> On 10.06.2015 10:38, Alexandre Julliard wrote:
>> What should happen is that Qian would submit a patch (to wine-patches,
>> where everybody can see it) then if you see something wrong with it,
>> instead of going ahead and making changes yourself, you tell Qian about
>> it (and CC wine-devel so that we are all aware of what's going on), and
>> let him address the issues and resubmit the patch. Repeat until the
>> patch is good enough.
>
> Hello Alexandre,
>
> It is a bit unrealistic that from now on everyone is going to submit their
> raw draft patches to wine-patches, although they need additional work.

Patches that are not meant to be committed can be sent to wine-devel for
discussion, or attached to their corresponding bug.

> I have to admit that the whole idea sounds nice, but based on my experience
> it doesn't really work very well. Such a method only works when every patch
> gets detailed and fair feedback, which is not the case at the moment. A lot
> of patches are not reviewed at all.
> I can perfectly understand that a lot of longtime wine developers don't want
> to mess around with patches of a very low quality, but what exactly should
> people learn from being ignored?

Sure, our community is not as nice as it could be, and a lot of us are
burned out on trying to help newbies. But the community is the sum of
its members, that's why we need people like you, with the skill and
motivation to help people that others may not feel like helping.

So I think it's unfortunate that instead of joining us and help improve
the behavior of the WineHQ community, you have chosen to fork your own
separate community, and are actively encouraging people to give up on
WineHQ and move over there.

Not only is it understandably perceived as a hostile move by a number of
veteran devs, it also doesn't solve the issue, because as I explained,
to get patches upstream people will be required to interact with the
community here. So this is where the problems have to be addressed.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list