winemac.drv: Improved App name on windows and menus (Mac Driver)

Huw Davies huw at codeweavers.com
Thu Jun 11 03:46:02 CDT 2015


On Wed, Jun 10, 2015 at 11:48:35AM -0300, Vitor Marques wrote:
> Although I have not tested, the changes are simple enough
> to be analyzed in sight.

Indeed they are, see below.  You really do need to test your patches.
And yes, gmail messed up the whitespace.
 
> diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m
> index 82925c8..a9d98c6 100644
> --- a/dlls/winemac.drv/cocoa_app.m
> +++ b/dlls/winemac.drv/cocoa_app.m
> @@ -214,14 +214,14 @@ - (void) transformProcessToForeground
>  
>              mainMenu = [[[NSMenu alloc] init] autorelease];
>  
> -            // Application menu
> -            submenu = [[[NSMenu alloc] initWithTitle:@"Wine"] autorelease];
> +            // Application name
>              bundleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:(NSString*)kCFBundleNameKey];
> +            if (!bundleName || ![bundleName lenght]) bundleName = @"Wine";

"lenght" is not what you want here.

Huw.



More information about the wine-devel mailing list