[PATCH 1/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 2).

Stefan Dösinger stefandoesinger at gmail.com
Mon Jun 15 14:10:26 CDT 2015

Am 11.06.2015 um 18:40 schrieb Aaryaman Vasishta <jem456.vasishta at gmail.com>:
> > +    memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID));
> I think an assignment should do the job.
> That was just to maintain consistency with the existing tests, I could still use an assignment if you want to.
Yes, please use assignments. Existing bad code is no excuse to write new bad code :-) .

> There's no need to try to set the display mode to 8. Also testing if changing the mode works is outside the scope of this test. What's interesting is that the pixel format of the primary surface of a new device after changing the mode.
> By chaning the mode you mean the dimentions/bpp or both?
Well, you're changing the mode, and then checking if the mode change applied. That made sense for your experiments with Windows 8 because SetDisplayMode didn't behave as intended. It does not make sense for an upstream d3drm test. For d3drm just check how the render target format changes when the device is created when a different screen mode is active.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150615/80e6e3cd/attachment.sig>

More information about the wine-devel mailing list