[PATCH 1/2] secur32: Added support for a few more algorithms in schannel_get_cipher_algid.

Jacek Caban jacek at codeweavers.com
Wed Jun 17 04:52:20 CDT 2015


Hi Hugh,

On 06/17/15 07:11, Hugh McMaster wrote:
> On Tue, 16 Jun 2015 13:46:32 +0200, Jacek Caban wrote:
>> -    case GNUTLS_CIPHER_AES_256_CBC: return CALG_AES;
>> +    case GNUTLS_CIPHER_AES_128_GCM: return CALG_AES_128;
>> +    case GNUTLS_CIPHER_AES_192_CBC: return CALG_AES_192;
>> +    case GNUTLS_CIPHER_AES_256_GCM:
>> +    case GNUTLS_CIPHER_AES_256_CBC: return CALG_AES_256;
> Those changes are causing fatal build errors in Wine:
>
> schannel_gnutls.c: In function ‘schannel_get_cipher_algid’:
> schannel_gnutls.c:272:10: error: ‘GNUTLS_CIPHER_AES_128_GCM’ undeclared (first use in this function)
>      case GNUTLS_CIPHER_AES_128_GCM: return CALG_AES_128;
>           ^
> schannel_gnutls.c:272:10: note: each undeclared identifier is reported only once for each function it appears in
> schannel_gnutls.c:274:10: error: ‘GNUTLS_CIPHER_AES_256_GCM’ undeclared (first use in this function)
>      case GNUTLS_CIPHER_AES_256_GCM:
>           ^
> make[1]: *** [schannel_gnutls.o] Error 1
> make[1]: Leaving directory `/home/hugh/wine-test/dlls/secur32'
> make: *** [dlls/secur32] Error 2

I sent a fix, please test [1].

BTW, while investigating it, I found that we will have more
compatibility issues in the future. It seems that gnutls doesn't
consider backward compatibility seriously [2].

Cheers,
Jacek

[1] http://source.winehq.org/patches/data/112128
[2]
https://gitlab.com/gnutls/gnutls/commit/b604a9093bccf933baba125634034a6d4ce9cbbf



More information about the wine-devel mailing list