[1/2] dimm.idl: Add IActiveIMMMessagePumpOwner.
Nikolay Sivov
bunglehead at gmail.com
Wed Jun 24 02:15:54 CDT 2015
On 24.06.2015 0:58, Thomas Faber wrote:
> On 2015-06-23 23:51, Nikolay Sivov wrote:
>> What's a reason for having it declared like that:
>>
>> --
>> + HRESULT OnTranslateMessage([in] const struct tagMSG *pMsg);
>> ---
>>
>> Why not use MSG*?
>
>
> Hmm I thought the compiler was complaining about not knowing MSG, but I
> must have imagined that, it's building fine now.
> I don't think it really makes a difference, but I can resend with that
> fixed in both files if you think it's cleaner.
Yes, I think there's no reason not to match SDK in that regard.
> [
> + object,
> + uuid(b5cf2cfa-8aeb-11d1-9364-0060b067b86e),
> + pointer_default(unique),
> + local
> +]
Why local? SDK idl doesn't have it.
> + HRESULT OnTranslateMessage([in] const struct tagMSG *pMsg);
> + HRESULT Pause([out] DWORD *pwdCookie);
> + HRESULT Resume([in] DWORD dwCookie);
Also please don't use prefixed notation, 'msg' and 'cookie' (in Pause
and Resume) would be better.
>
> Thanks,
> Thomas
>
More information about the wine-devel
mailing list