[PATCH] msvcp90: Implement time_get<char> ctors and dtors

Daniel Lehman dlehman at esri.com
Fri Jun 26 11:37:24 CDT 2015


> -----Original Message-----
> From: Piotr Caban [mailto:piotr.caban at gmail.com]
> Sent: Friday, June 26, 2015 8:44 AM
> To: Daniel Lehman
> Cc: wine-devel at winehq.org
> Subject: Re: [PATCH] msvcp90: Implement time_get<char> ctors and dtors
> 
> On 06/26/15 16:51, Daniel Lehman wrote:
> > +    days = _Locinfo__Getdays((_Locinfo *)locinfo);
> Could you please change _Locinfo__Getdays header and make the cast
> there? Thanks to it we will much _Locinfo__Getdays mangled name. Also
> _Locinfo__W_Getmonths, _Locinfo__Getmonths and _Locinfo__W_Getdays
> header needs to be fixed. This will make this cast not needed.
> 

the string c/dtors need a cast to non-const.  would it be ok to do the cast in the macros at the top?

something like:
#define locale_string_char_dtor(this)	_Yarn_char_dtor((locale_string *)this) 

Then the casts are in one spot and don't need to be sprinkled about

Thanks
daniel






More information about the wine-devel mailing list