[PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

Piotr Caban piotr.caban at gmail.com
Mon Jun 29 04:29:21 CDT 2015


On 06/27/15 19:49, YongHaoHu wrote:
> +        ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, tests[i].fail_if_exists);
> +        ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test %d expect: %d, got %d\n", i+1, GetLastError(), ret);
> +        ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d errno expect 0xdeadbeef, got %d\n", i+1, errno);
Please check the return value of the function explicitly. Currently your 
implementation returns error while it should succeed and it's not 
visible in the tests.

Thanks,
Piotr



More information about the wine-devel mailing list