[PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.
piotr.caban at gmail.com
Mon Jun 29 09:51:43 CDT 2015
On 06/29/15 16:40, YongHaoHu wrote:
> On 15/6/29 下午5:29, Piotr Caban wrote:
>> On 06/27/15 19:49, YongHaoHu wrote:
>>> + ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest,
>>> + ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test
>>> %d expect: %d, got %d\n", i+1, GetLastError(), ret);
>>> + ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d
>>> errno expect 0xdeadbeef, got %d\n", i+1, errno);
>> Please check the return value of the function explicitly. Currently
>> your implementation returns error while it should succeed and it's not
>> visible in the tests.
> Because the last error handling is not correct in CopyFile, I check
> GetLastError() instead of values. Do you have any good idea?
If testing exact return value of function is hard please at least test
if function succeeds/fails when it should. Currently your implementation
sometimes returns error even so it succeeds.
More information about the wine-devel