An issue with msvcp110 test's design

Nikolay Sivov bunglehead at
Sun Mar 15 06:45:07 CDT 2015

On 15.03.2015 11:50, YongHao Hu wrote:
> Hi, all
> Thanks for Piotr's comment on my GSOC ideas.
> In order to have a good knowledge of functions from tr2 namespace, I had
> made a test and written some functions' implementation.
> However, I had an issue with msvcp test's design when I need to free
> library of msvcp90 and load msvcp110.
> 619 static HMODULE msvcr, msvcp;
>   620 #define SETNOFAIL(x,y) x = (void*)GetProcAddress(msvcp,y)
>   621 #define SET(x,y) do { SETNOFAIL(x,y); ok(x != NULL, "Export '%s'
> not found\     n", y); } while(0)
> In my patch, I use a hmodule variable named msvcp90 to save msvcp90
> hmodule and then reuse msvcp to save msvcp110.
> As far as I am concerned, the name msvcp90 or msvcp90_saver is not good
> enough. Could you give it a good name?
> And the other method I came up with is  undefining SETNOFAIL and SET and
> using msvcp110 to define it again, which I think is ugly.
> By the way, my crosstest on all the testbots[1] show that msvcp110.dll
> or msvcrt110.dll not installed.
> It seems testbot doesn't install msvcp110.
> I will be grateful for any advice you can provide.
> [1]:

This class is only present in 11.0 and 12.0 libs, right? Why not add 
such tests to msvcp110/tests?

More information about the wine-devel mailing list