[PATCH] findstr: Added test for findstr.
kaipeng94 at gmail.com
Mon Mar 23 10:16:57 CDT 2015
Thanks for your several suggestions .
I had planned to submit test first and make "Implement findstr.exe for Wine"
as my GSoC proposal.
Do you think it is ok to as a GSoC proposal?
Can you give me some suggestions?
2015-03-23 19:12 GMT+08:00 Stefan Dösinger <stefandoesinger at gmail.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Thanks for your patch! I have a few comments:
> Am 2015-03-23 um 04:14 schrieb Kaipeng Zeng:
> > index 5f5e9d5..f3056c7 100755
> > --- a/configure
> > +++ b/configure
> You don't have to include the change to configure in your patch,
> Alexandre will update it himself.
> > diff --git a/configure.ac b/configure.ac
> > index d23227a..822affe 100644
> > ...
> > WINE_CONFIG_PROGRAM(findstr,,[install])
> > +WINE_CONFIG_TEST(programs/findstr/tests)
> > WINE_CONFIG_PROGRAM(hh,,[install])
> I don't think we have any precedent for having tests without having at
> least a stub implementation. Personally I don't see anything wrong
> with having just a test for now. Can you make sure that the test is
> properly built and included in winetest.exe?
> Do you intend to implement the program itself?
> > +static DWORD runcmd(const char* cmd, char *output)
> > ...
> > + CloseHandle(hRead);
> > + return TRUE;
> > +}
> I think it would be a good idea to return the return value of findstr
> here instead of always returning true when CreateProcess succeeds.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> -----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the wine-devel