[PATCH] advapi32: succeed for null pointer in ChangeServiceConfig2

[Bernhard Übelacker]

Hello Nikolay, hello Stefan,


Am 19.03.2015 um 18:57 schrieb Nikolay Sivov:> So bottom line is that 
you should start with a simple test like that one:
 >
 > - change to NULL description from a not-NULL one;
 > - query it back to see what's returned.
 >
 > Once we have a test for that it will be easy to fix this issue.

Would this patch for the test side be acceptable?
https://testbot.winehq.org/JobDetails.pl?Key=12322

And should the test be switched to the *A functions?
https://testbot.winehq.org/JobDetails.pl?Key=12374



Am 20.03.2015 um 12:17 schrieb Stefan Dösinger:
 > Adding the test like this may work, but I don't think it is the right
 > way. This call may overwrite settings set by the previous
 > ChangeServiceConfig2A call if it succeeds. If it fails (and doesn't
 > crash) the test can continue just fine since the previous call set up
 > the configuration.
 >
 > I think it would be better to move this into its own test.

Would it be sufficient to move the changes behind the other accesses to 
the description in the same test? So there is no need to jump to cleanup 
on failure.



Kind regards,
Bernhard