[PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

Piotr Caban piotr.caban at gmail.com
Thu Mar 26 15:45:41 CDT 2015


On 26/03/15 19:21, Sebastian Lackner wrote:
> On 26.03.2015 19:10, Piotr Caban wrote:
>> The inheritance doesn't occur when function from ntdll are used for
>> setting DACL. This makes your code inside server incorrect. Also your
>> code is not checking handle permissions correctly.
> does that mean you reviewed our code? Would you please give some more details to us about the error you found?
> Feel free to open a bug report on bugs.wine-staging.com with your results.
I've not really reviewed it, I've only skimmed the diff. According to my 
testing NtSetSecurityObject is only setting supplied DACL, it's not 
adding inherited entries.

I also haven't seen the implementation from wine-staging tree earlier (I 
think these patches were not mentioned anywhere on wine bugzilla/were 
never sent to wine but maybe I've missed something).


More information about the wine-devel mailing list