[2/3] ntdll: Introduce a helper function to check for existance of server handles.

Sebastian Lackner sebastian at fds-team.de
Mon May 4 04:11:44 CDT 2015


On 04.05.2015 09:25, Alexandre Julliard wrote:
> Sebastian Lackner <sebastian at fds-team.de> writes:
> 
>> @@ -1417,6 +1417,7 @@
>>  # Server interface
>>  @ cdecl -norelay wine_server_call(ptr)
>>  @ cdecl wine_server_fd_to_handle(long long long ptr)
>> +@ cdecl wine_server_handle_exists(long long)
>>  @ cdecl wine_server_handle_to_fd(long long ptr ptr)
>>  @ cdecl wine_server_release_fd(long long)
>>  @ cdecl wine_server_send_fd(long)
> 
> Why do you need a new export for this?  Is it just to avoid a dup() call
> or is there another reason?
> 

The main idea was to avoid the unnecessary dup()/close() in situations where
no file descriptor is required.

BTW: Even if patch 2 is accepted, I'd like to resend patch 3 in order to replace FILE_READ_DATA -> 0.
I'll wait for your opinion on patch 1 and 2 first before resending.




More information about the wine-devel mailing list