[PATCH 1/2] kernel32: Implement GetSystemTimePreciseAsFileTime
Martin Storsjö
martin at martin.st
Tue May 12 12:03:13 CDT 2015
On Tue, 12 May 2015, Andrew Eikum wrote:
> On Thu, May 07, 2015 at 11:02:34PM +0300, Martin Storsjo wrote:
>> +/***********************************************************************
>> + * GetSystemTimePreciseAsFileTime (KERNEL32.@)
>> + *
>> + * Get the current time in utc format, with <1 us precision.
>> + *
>> + * RETURNS
>> + * Nothing.
>> + */
>> +VOID WINAPI GetSystemTimePreciseAsFileTime(
>> + LPFILETIME time) /* [out] Destination for the current utc time */
>> +{
>> + GetSystemTimeAsFileTime(time);
>> +}
>
> I don't know why this one's not getting in. I have a couple small
> guesses.
>
> Personally, I'm opposed to including a bunch of documentation in Wine.
> I don't think Wine is the right place to document the Windows API. I
> don't know if others feel this way, or if this is enough for
> rejection.
>
> You're also using VOID, LPJUNK, etc, which I think we're trying to
> avoid these days.
Ok, thanks. In this case, it's pretty much a copypaste of the existing
GetSystemTimeAsFileTime() function, with the body swapped out, and with
the function comment extended (because to me it's quite puzzling why
there's two separate functions). Since different parts of the codebase use
different conventions, I've tried to match the surrounding style unless
otherwise suggested.
// Martin
More information about the wine-devel
mailing list