msvcirt: Share exceptions implementation with msvcp

Alexandre Julliard julliard at winehq.org
Tue May 26 00:41:37 CDT 2015


Iván Matellanes <matellanesivan at gmail.com> writes:

> This is the first patch of my GSoC project :)
> It implements the exceptions in msvcirt by using the code in msvcp90.

> @@ -304,13 +304,15 @@ typedef enum __exception_type {
>      EXCEPTION_RERAISE,
>      EXCEPTION,
>      EXCEPTION_BAD_ALLOC,
> -    EXCEPTION_BAD_CAST,
>      EXCEPTION_LOGIC_ERROR,
> +#ifndef _MSVCIRT
>      EXCEPTION_LENGTH_ERROR,
>      EXCEPTION_OUT_OF_RANGE,
>      EXCEPTION_INVALID_ARGUMENT,
>      EXCEPTION_RUNTIME_ERROR,
>      EXCEPTION_FAILURE,
> +    EXCEPTION_BAD_CAST,
> +#endif

Please avoid as many ifdefs as possible. For instance, having extra
enums or unexported functions doesn't do any harm, so there's no reason
to make a special case for them.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list