[PATCH] d3d11.idl: add the basic interfaces to enable video decoding

Steve Lhomme robux4 at gmail.com
Tue May 26 03:09:39 CDT 2015


On Sun, May 24, 2015 at 8:03 AM, Steve Lhomme <robux4 at videolabs.io> wrote:
> Any update on this patch ? Should I submit again with the one space removed ?

I'm sending the updated version.

> Steve
>
> On Wed, May 13, 2015 at 11:06 AM, Steve Lhomme <robux4 at videolabs.io> wrote:
>> On Wed, May 13, 2015 at 1:02 PM, Stefan Dösinger
>> <stefandoesinger at gmail.com> wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi,
>>>
>>> This patch looks better. Ultimately Henri and Alexandre have to decide
>>> if they're happy with it. Henri is on vacation this week, so don't
>>> expect much movement until Monday.
>>
>> No problem.
>>
>>> Am 2015-05-11 um 15:41 schrieb Steve Lhomme:
>>>> +interface ID3D11VideoDecoderOutputView : ID3D11View
>>>> +{
>>>> +    void GetDesc(
>>>> +        [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc );
>>>> +}
>>> There's a space that doesn't match the rest of the patch, but does match
>>> what's in the MS headers. Since it is the only case I can spot I think
>>> it's a typo in a self-typed header rather than a missed fixup in a
>>> copypasted header.
>>
>> Should I resubmit without the extra space ?
>>
>>> You don't have to use the same parameter names in Methods or functions.
>>> Instead of "pDesc" you can e.g. use "desc". The rest of the header
>>> already uses pCrap though, so I'm ok with the current way.
>>
>> I checked the other d3d IDL files in the repo to match what's already
>> in use and pDesc is very common, for example in d3d10.idl.
>>
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v2
>>>
>>> iQIcBAEBAgAGBQJVUy8wAAoJEN0/YqbEcdMwXHwQAJd+LDxvH03XR5L/+bpxZB/o
>>> U6g7cgMmtkklfSeCazZrUe0R5ZZExbmmIN+bBr6GJpbQezVQW3vng9EQj6ihfBjf
>>> 6CEKr9BJF/xOhYdHPrhg3yxaD9MZrnsXa9llNFGds6SI0q1L8uCclyAuPxV+AoSO
>>> fxgElN7/+LCRTwEM9shdwuxVELrikW52UmVTEajhNematVixplOh6pJMe+8XyPp/
>>> iSn+6p/jBeytKzjb83uUnyGqVaFLOIg9ywR2PPeA43RvNYVnfV9agxeOGJYvO7Zw
>>> mKWmv+fG9sIXzvF/G9upnceE69YHf8WoIdEHW+kZsOl2ctRRB4ycBHp0rG4s2IeH
>>> f1XpENP55lT+dYIc/Tef8IdpABzmGD7JwtnbLyxRbF4F9Qwfe6x7GP3VtEBp1M/+
>>> 5nePonYZ4N55sShelaU8X7/JxUuZb8onlz1UfEXJkIykopyQJJw49rXkQv7OFm2k
>>> xyJAsXCQk5Z9sqXXBuFxUnKkip9P8UaLOwFJ8WFUVgHrkS9UAceiehUKgvpcwYfX
>>> vxh48j6gAE4fBEUBVOlXiR4lMV7cDUWIoJdCopUkzxysPMp/hi3BcDk7EdrF9LX9
>>> c01jQc2N+JwzjIyNhSC01Jk23Qp2lOG+pUT1UrKcACesoB1H6Zm3QbNv5hVgUfkz
>>> pFuJsryqPWxQFS02SvTu
>>> =ToVh
>>> -----END PGP SIGNATURE-----



More information about the wine-devel mailing list