[PATCH 5/5] wined3d: Always enable GL_PROGRAM_POINT_SIZE in the GLSL backend.

Henri Verbeet hverbeet at gmail.com
Thu May 28 16:43:45 CDT 2015


On 28 May 2015 at 23:23, Matteo Bruni <mbruni at codeweavers.com> wrote:
> @@ -6987,6 +7006,13 @@ static void shader_glsl_select(void *shader_priv, struct wined3d_context *contex
>      GLuint program_id = 0, prev_id = 0;
>      GLenum old_vertex_color_clamp, current_vertex_color_clamp;
>
> +    if (!ctx_data->backend_init_done)
> +    {
> +        gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE);
> +        checkGLcall("GL_PROGRAM_POINT_SIZE");
> +        ctx_data->backend_init_done = TRUE;
> +    }
> +
Is this shared state between contexts? Otherwise you need to do this
once for every context. Also, shader_glsl_select() is kind of a hot
path, it may be better to just add an entry to struct
wined3d_shader_backend_ops for this kind of initialization.



More information about the wine-devel mailing list