[PATCH] winex11: Avoid double initialization of variables in OpenGL functions.
madewokherd at gmail.com
Wed Nov 4 11:41:25 CST 2015
>> Your diff appears to have a huge amount of context around the changes. Is that intentional?
> It was an attempt to make reviewing easier. You can see from the
> expanded context that these variables are initialized once, then
> initialized again, and never used in between.
For what it's worth, my approach when reviewing has been to apply the
patch locally (by piping 'curl' from the patch tracking website to
'git am') and viewing the commit in gitk, which allows me to decide
exactly how much context I want, or just view the new version in an
editor. I have to do that anyway to run the tests.
More information about the wine-devel