[PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
Dmitry Timoshkov
dmitry at baikal.ru
Tue Nov 10 08:09:52 CST 2015
Nikolay Sivov <nsivov at codeweavers.com> wrote:
> +BOOL WINAPI EnumTimeFormatsA(TIMEFMT_ENUMPROCA proc, LCID lcid, DWORD flags)
> {
> - WCHAR buf[256];
> + struct enumtimeformats_context ctxt;
>
> - if (!proc)
> + /* EnumTimeFormatsA doesn't support flags, EnumTimeFormatsW does. */
> + if (flags & ~LOCALE_USE_CP_ACP)
> {
> - SetLastError(ERROR_INVALID_PARAMETER);
> + SetLastError(ERROR_INVALID_FLAGS);
Is there any particular reason that you need 3/4 in order to fix something
you've added in 2/4? This looks like badly tested code.
--
Dmitry.
More information about the wine-devel
mailing list