[v2 PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation

Dmitry Timoshkov dmitry at baikal.ru
Tue Nov 10 08:57:17 CST 2015


Nikolay Sivov <bunglehead at gmail.com> wrote:

> >> -BOOL WINAPI EnumTimeFormatsW(TIMEFMT_ENUMPROCW proc, LCID lcid, DWORD flags)
> >> +BOOL WINAPI EnumTimeFormatsA(TIMEFMT_ENUMPROCA proc, LCID lcid, DWORD flags)
> >>   {
> >> -    WCHAR buf[256];
> >> +    struct enumtimeformats_context ctxt;
> >>
> >> -    if (!proc)
> >> +    /* EnumTimeFormatsA doesn't support flags, EnumTimeFormatsW does. */
> >> +    if (flags & ~LOCALE_USE_CP_ACP)
> >>       {
> >> -        SetLastError(ERROR_INVALID_PARAMETER);
> >> +        SetLastError(ERROR_INVALID_FLAGS);
> >
> > This change doesn't seem to be confirmed by a test case.
> >
> 
> It is. Removed error is for 'proc' check, that is moved by this patch.

I see, thanks.

-- 
Dmitry.



More information about the wine-devel mailing list