[v7 05/10] ddraw: Check if surface is a mipmap sublevel through caps in ddraw_surface7_GetPriority().

Riccardo Bortolato rikyz619 at gmail.com
Thu Nov 12 04:57:12 CST 2015


Hi Henri,

I will fix the line, as for the test it should be handled already by
test_resource_priority():

[...]
    hr = IDirectDrawSurface7_GetPriority(mipmap, &priority);
    ok(hr == DDERR_INVALIDPARAMS, "Got unexpected hr %#x, type managed
mipmap.\n", hr);
[...]

Ciao,
Riccardo

2015-11-12 11:05 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 10 November 2015 at 14:09, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>> -    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) || !surface->wined3d_texture)
>> +    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) || (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL))
>
> This line is still too long. Stefan already mentioned that this causes
> a behaviour change and should have a test.
>
>



More information about the wine-devel mailing list