msi: Use the intended attributes when overwriting the target file in cabinet_copy_file.

Hans Leidekker hans at
Mon Nov 23 08:17:50 CST 2015

On Mon, 2015-11-23 at 14:13 +0100, Thomas Faber wrote:
> The current code uses the old file's attributes, which means it would
> make the file read-only again. This would e.g. prevent the deletion of
> the file at the end of test_readonlyfile_cab (and should probably even
> make this CreateFileW call fail since it specifies GENERIC_WRITE).
> The reason this currently works in Wine is that CreateFile keeps the
> existing file attributes in this case (see the todo_wine in
> test_NtCreateFile).
> The patch fixes msi to use the correct attributes as returned by the
> callback.

Looks good but if it doesn't fix a real installer I think we should hold
off until the freeze is over.

More information about the wine-devel mailing list