Fix warning: logical not is only applied to the left hand side of this comparison

Nikolay Sivov bunglehead at gmail.com
Thu Nov 26 15:18:03 CST 2015


On 26.11.2015 22:51, Sven Baars wrote:
> On 26-11-15 18:07, Bruno Jesus wrote:
>> On Thu, Nov 26, 2015 at 3:11 AM, Sergey Isakov <isakov-sl at bk.ru> wrote:
>>> It may cause a mistake if will work not as intended.
>>>
>>> Signed-off-by: Sergey Isakov <isakov-sl at bk.ru>
>> Hi, Sergey. Please split your changes to 1 patch per DLL and adjust
>> the subject line according to the guidelines
>> (http://wiki.winehq.org/SubmittingPatches) for example:
>>
>> msi/tests: Simplify the logic in a if condition
>> tapi32: Simplify the logic in a if condition
>> winex11.drv: Simplify the logic in a if condition
>>
>>
> It also seems to me that you did not compile or test your code. The last
> line you changed randomly adds an extra bracket.

winex11.drv part is fixed in git now.

>
> Cheers,
> Sven
>
>




More information about the wine-devel mailing list