wininet: Fix allocation error handling (Clang)

Jacek Caban jacek at codeweavers.com
Mon Nov 30 04:47:01 CST 2015


Hi André,

On 11/29/15 19:53, André Hentschel wrote:
> diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c
> index 4784b33..0b7f5e1 100644
> --- a/dlls/wininet/cookie.c
> +++ b/dlls/wininet/cookie.c
> @@ -713,7 +713,8 @@ DWORD get_cookie_header(const WCHAR *host, const WCHAR *path, WCHAR **ret)
>  
>              *ret = header;
>          }else {
> -            res = ERROR_NOT_ENOUGH_MEMORY;
> +            LeaveCriticalSection(&cookie_cs);
> +            return ERROR_NOT_ENOUGH_MEMORY;

How about returning res in the bottom of the function?

Thanks,
Jacek



More information about the wine-devel mailing list