rsaenh: Remove dead assignments (Clang)

André Hentschel nerv at dawncrow.de
Mon Nov 30 13:29:49 CST 2015


Am 30.11.2015 um 09:51 schrieb Marcus Meissner:
> On Mon, Nov 30, 2015 at 01:39:09AM +0300, Nikolay Sivov wrote:
>> On 30.11.2015 0:31, André Hentschel wrote:
>>> Signed-off-by: André Hentschel <nerv at dawncrow.de>
>>> ---
>>>  dlls/rsaenh/sha2.c | 21 ---------------------
>>>  1 file changed, 21 deletions(-)
>>
>> This and advapi32 looks like was done on purpose. Why are you removing that?
> 
> The usual idea in cryptography is to zeroize temporary components. 
> 
> The compiler will optimize away however if its just stack space :(
> 

That's exactly the reason, compilers would maybe only care about it with -O0



More information about the wine-devel mailing list