[v3 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
rikyz619 at gmail.com
Wed Oct 7 06:24:40 CDT 2015
I can quickly edit the commit message and re-submit the patches if
this won't affect their time-to-commit (as I already have other 20+
kind of ready for review in my queue).
As for the volume_init change I put it in this one as it felt kind of
trivial (a matter of positioning the wined3d_texture_get_parent). If
I can I'd like to avoid rebasing once more as this serie is already
compile-and-make-tested (my current setup with a 32bit lxc container
for compilation is a major PITA when rebasing and testing a serie, as
I already mentioned to Stefan..I will hopefully compile on bare metal
someday, so I can use git hooks to handle testing&compiling).
2015-10-07 12:56 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
> On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>> Store wined3d_texture and sub_resource in d3d8_volume.
>> Updated the d3d8_volume_LockBox to make use of wined3d_texture_map.
>> Also updated d3d9, d3d11, ddraw callbacks accordingly
> This is mostly fine, although "d3d8: Use wined3d_texture_map() in
> d3d8_volume_LockBox()." would perhaps have been more appropriate as a
> subject, since the callback change is just a side-effect. The d3d9
> volume_init() change could have been deferred until patch 6/10 and
> would perhaps been more appropriate there, but it doesn't matter too
More information about the wine-devel