[PATCH 2/2] reg: merge key open code
stefandoesinger at gmail.com
Thu Oct 8 08:11:58 CDT 2015
-----BEGIN PGP SIGNED MESSAGE-----
Am 2015-10-08 um 10:14 schrieb Michel Zou:
> I saw the 1/2 patch has been commited, this is the second half that
> corresponds to the commit 1 of 4 by jnvsor in a preliminary work to
> add reg query functionality:
> https://github.com/jnvsor/wine/commits/reg.exe I split this commit
> in two after the review from Stefan Dösinger. I did not want to
> submit all at once because it seems pretty hard to get patches
I'd say prepare the other patches as well and re-submit this one
together with the changes that need the code refactoring. The
reg_open_path change should probably go along with Clean up reg_add
(same submission to wine-patches, but a separate patch).
reg: Add wchar/raw data conversion functions adds functionality, but
it can be split a bit. Afaics a split like this would make sense. As
far as I can see all of those steps should fix some todo_wines, so
they'll make sense on their own.
1) Improve REG_DWORD. Though why again do you need the manual 0 / 0x /
0X detection? It seems that strtolW should be able to do that as well.
(Jonathan explained it to me once, but I forgot).
2) Add REG_DWORD_BIG_ENDIAN. One liner, plus remove todo_wines
3) Handle empty input
4) Add REG_MULTI_SZ
5) Add REG_BINARY
6) Constify the parameters. While doing so you can also change
"LPCRAP" to "CRAP *"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
-----END PGP SIGNATURE-----
More information about the wine-devel