[PATCH 2/2] reg: merge key open code

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-10-08 um 10:14 schrieb Michel Zou:
> I saw the 1/2 patch has been commited, this is the second half that
> corresponds to the commit 1 of 4 by jnvsor in a preliminary work to
> add reg query functionality: 
> https://github.com/jnvsor/wine/commits/reg.exe I split this commit 
> in two after the review from Stefan Dösinger. I did not want to 
> submit all at once because it seems pretty hard to get patches 
> accepted.
I'd say prepare the other patches as well and re-submit this one
together with the changes that need the code refactoring. The
reg_open_path change should probably go along with Clean up reg_add
(same submission to wine-patches, but a separate patch).

reg: Add wchar/raw data conversion functions adds functionality, but
it can be split a bit. Afaics a split like this would make sense. As
far as I can see all of those steps should fix some todo_wines, so
they'll make sense on their own.

1) Improve REG_DWORD. Though why again do you need the manual 0 / 0x /
0X detection? It seems that strtolW should be able to do that as well.
(Jonathan explained it to me once, but I forgot).

2) Add REG_DWORD_BIG_ENDIAN. One liner, plus remove todo_wines

3) Handle empty input

4) Add REG_MULTI_SZ

5) Add REG_BINARY

6) Constify the parameters. While doing so you can also change
"LPCRAP" to "CRAP *"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWFmueAAoJEN0/YqbEcdMwZHwP/R/H4kN4pIsN4j/3jDAensRL
NwN5kVgaC33WWxG6ZtydJhiIo5ungcw3KZtJ78CL0+7pVDiwyodUDjbcM0MMGBpF
lAais1yXn98Uf2tla1sRDVmsoYHMUfGxjN6uJ5225/WmL042iQunQA+NLPdZOOzK
b05KlhK7h6/AfSL0rKKh+4COlGHhS2s5dbXtsbz6exK6BMzMIJsG0EYPfGxAF//6
LCgyFtWSvahBBjqU/7FsXwW2uGL81NTC0OQPY7o6CgJin0Yg8+HUCLU8vleF/4VI
U/m/1hwOqTYM9UsAl2irYsprElmH/WCThZrTRskgE2ABahicc9Wz3iTlwy83VwXw
qZRF5ceGLYhvrQd6YePc4dD9ODLJSMjtnz3mEAyEi0JtY/6SOHD34VFhsl4aped1
irqnByBLiC1VJDYTK3zc1264FQuVjGbgsw3w1REpLic/8twZetuY/EMg9N44mOPu
jeIA9zCA8JXp29F+9sUkcDusExyZqvKy1HE7GapfK5/F7w/epz/IVQLE0E0wO7KC
5kyxmLpHM22zlxCKW+cN58/TXAW2wtE3/T3POT/kTBPDKc0tSwLGL2yuC28BfwnF
HM64gq0r05OFQrOQSSXDte4MTGBUoELstd/y2RtjTQz/qNMhWzLSNiuKdDXWkILB
uIoXAIXWCGrT0U92PNBI
=whL+
-----END PGP SIGNATURE-----