[PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 2).

[Sebastian Lackner]

On 08.10.2015 03:11, Erich E. Hoover wrote:
> This patch adds support for the basic file-transfer operation of
> TransmitFile.  It reads the file in as "bytes_per_send" chunks, which
> it then sends to the destination using WS2_send.  This process is
> repeated synchronously (until patch 5 adds async support) until the
> entire file is sent.
> 
> This version has been updated to use a simple APC-safe NtReadFile-like
> routine instead of using NtReadFile.
> 
>
> +    else if (errno != EAGAIN)
> +        status = wsaErrno();

wsaErrno() doesn't return a status.

Nevertheless, the more critical issue / question I see is, if we want to duplicate
ReadFile code into ws2_32. The ntdll version is already very complicated, and your
minimal version might not always be sufficient.

* Missing handling for server_read_file().
* FILE_GetNtStatus() doesn't match sock_get_ntstatus() exactly.
* FD type dependent code is probably simplied a bit too much. The original code
  behaves different depending on the exact FD_TYPE_* at some places.
* NtReadFile will very likely get even more complicated over time, for example when
  a proper solution for message mode pipes is implemented.