[PATCH 2/5] wined3d: Pass a context to read_from_framebuffer.

Matteo Bruni matteo.mystral at gmail.com
Tue Oct 13 06:43:28 CDT 2015

2015-10-13 12:53 GMT+02:00 Stefan Dösinger <stefandoesinger at gmail.com>:
> Henri once upon a time didn't like this (I haven't looked for my
> previous patch attempt from 2 years ago) and suggested a
> context_restore call instead. This is what I did here.
> I guess it would be nicer if context_restore accepted two contexts,
> but we're intentionally not using a separate GL context nor struct
> wined3d_context for backbuffer offscreen rendering. Neither the GL
> context switch nor keeping track of all d3d states is necessary for
> backbuffer ORM to do its job.

True that. The handling of context->render_offscreen and related
states is a mess (not to mention the bugs it has caused over time) :/

I guess my reservations have mostly to do with acquiring and
immediately releasing the context to restore the previous state,
although it looks like avoiding that dance would practically require
reimplementing context_acquire() inside context_restore() so meh...

More information about the wine-devel mailing list