[PATCH 3/7] wined3d: make wined3d_device_get_front_buffer_data work with wined3d_texture and sub_resource_index

Henri Verbeet hverbeet at gmail.com
Tue Oct 13 10:04:36 CDT 2015

On 12 October 2015 at 17:23, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>  HRESULT CDECL wined3d_device_get_front_buffer_data(const struct wined3d_device *device,
> -        UINT swapchain_idx, struct wined3d_surface *dst_surface)
> +        UINT swapchain_idx, struct wined3d_texture *texture, unsigned int sub_resource_idx)
>  {
> +    struct wined3d_resource *sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx);
I'd rather have the wined3d_texture_get_sub_resource() call after the
TRACE. It's not too much of an issue, but it does affect the order of
the traces in the debug output.

> -    TRACE("device %p, swapchain_idx %u, dst_surface %p.\n", device, swapchain_idx, dst_surface);
> +    TRACE("device %p, swapchain_idx %u, texture %p, sub_index %u.\n", device, swapchain_idx, texture, sub_resource_idx);
And please just match the parameter name here.

More information about the wine-devel mailing list