[PATCH] vbscript/tests Add array out of bounds test
leslie_alistair at hotmail.com
Thu Oct 22 01:56:22 CDT 2015
On 21/10/15 23:49, Jacek Caban wrote:
> Hi Alistair,
> On 10/20/15 10:05, Alistair Leslie-Hughes wrote:
>> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
>> dlls/vbscript/tests/lang.vbs | 5 +++++
>> dlls/vbscript/tests/run.c | 17 ++++++++++++++++-
>> 2 files changed, 21 insertions(+), 1 deletion(-)
> This seems more complicated than it has to be. Is there any reason you
> don't use parse_script_ar helper?
I was trying to mimic the way we use scripting, thus the GetDispID call,
besides I didn't knowing about parse_script_ar.
After some more investigation, I think the real issue is that the
site->OnScriptError isn't being called when the script causes an error.
I've attached a new patch which highlights the missing OnScriptError
calls. What do you think?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5052 bytes
Desc: not available
More information about the wine-devel