d3d8types.h: Convert the D3DVSD_...SHIFT constants to unsigned.
hverbeet at gmail.com
Mon Oct 26 03:31:44 CDT 2015
On 24 October 2015 at 23:38, Gerald Pfeifer <gerald at pfeifer.com> wrote:
> On Sat, 24 Oct 2015, Gerald Pfeifer wrote:
>> This avoids potential shift overflows. I only should be necessary
>> for D3DVSD_TOKENTYPESHIFT, but it makes sense to have this consistent.
> Correction, this per se does not avoid shift overflows, I sent an
> older patch. It still may make sense to apply (please advise), but
I don't think it really makes sense to make the shifts unsigned. There
might be an argument for consistently using unsigned constants unless
they need to be signed, but that would be a much larger change.
More information about the wine-devel