[PATCH] d3dx9_36: Supplying a AnimationController isn't an error

Mon Oct 26 05:06:49 CDT 2015

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-10-26 um 09:56 schrieb Alistair Leslie-Hughes:
> +    if (anim_controller) {
> +        *anim_controller = NULL;
> +
> +        FIXME("Animation controller creation not implemented\n");
> +    }
Do you have an easy way to write this FIXME only if the file has an
AnimationSet node? Or maybe even keep returning E_NOTIMPL if the
output should be non-NULL?

Also the style doesn't follow the general d3d style ('{' goes in its
own line).

> +        ok(frame_hier->Name == NULL, "Expected NULL, got '%s'\n", frame_hier->Name);
> +        D3DXMatrixIdentity(&transform);
> +        check_matrix(&frame_hier->TransformationMatrix, &transform);
It looks like these are the same tests as the ones right above the
call. I'd skip them and only have controller-related test.

A test input that should result in a non-NULL controller would be
helpful as well.