[PATCH] ucrtbase: Implement some printf functions

Piotr Caban piotr.caban at gmail.com
Mon Oct 26 05:11:49 CDT 2015


Hi,

On 10/20/15 10:50, Martin Storsjö wrote:
> FWIW, this gives warnings about puts_clbk_str_c99_w being defined but
> unused. It will be necessary later in case someone wants to implement
> the wchar versions of the printf functions for ucrtbase, but what should
> be done in the meantime? Just define this function somewhere else in
> wcs.c instead?
I don't think it's useful to add some kind of workaround in this case. 
The function will be needed when e.g.
__stdio_common_vfwprintf is implemented. The simplest solution is to 
include implementation of wchar_t variant of the function in this patch.

Please note that your tests are failing in 64-bit wine:
../../../../wine_src/tools/runtest -q -P wine -T ../../.. -M 
ucrtbase.dll -p ucrtbase_test.exe.so printf && touch printf.ok
fixme:msvcrt:pf_printf_a multibyte characters printing not supported
printf.c:167: Test failed: buf = containsmnull

fixme:msvcrt:pf_printf_a multibyte characters printing not supported
printf.c:194: Test failed: buf = containscnull


Makefile:160: recipe for target 'printf.ok' failed
make: *** [printf.ok] Error 2

Thanks,
Piotr



More information about the wine-devel mailing list