d3dx9: Add adjacency generation for D3DXCreateCylinder()

Matteo Bruni matteo.mystral at gmail.com
Mon Oct 26 13:39:58 CDT 2015

2015-10-26 19:18 GMT+01:00 Gediminas Jakutis <gediminas at varciai.lt>:
> On 2015.10.26 19:52, Matteo Bruni wrote:
>> 2015-10-26 14:33 GMT+01:00 Gediminas Jakutis <gediminas at varciai.lt>:
>>> ---
>>>  dlls/d3dx9_36/mesh.c | 23 +++++++++++++++++------
>>>  1 file changed, 17 insertions(+), 6 deletions(-)
>> Please resend with your Signed-off-by tag, preferably via git send-email.
> Done.


>> Otherwise the patch looks good to me. Some kind of test for the
>> adjacency data would be nice to have, maybe in a followup patch...
> Good day!

Hi :)

> This code is identical (save for variable names) to adjacency generation
> portion of commit fe802d92bbe40d68e3ce61e1f30de1f0db531224
> The way it is structured, adding tests would in essence be just an indirect
> test for the GenerateAdjacency function. Which is why the aforementioned commit
> it was based off does not include such tests, either.

Yes, I know, but that is an implementation detail. Native might not do
the same and in any case the tests should not care about what the
implementation does or doesn't do.

More information about the wine-devel mailing list