d3dx9: Add adjacency generation for D3DXCreateCylinder()

Matteo Bruni matteo.mystral at gmail.com
Mon Oct 26 13:41:36 CDT 2015

2015-10-26 19:39 GMT+01:00 Matteo Bruni <matteo.mystral at gmail.com>:
> 2015-10-26 19:18 GMT+01:00 Gediminas Jakutis <gediminas at varciai.lt>:
>> This code is identical (save for variable names) to adjacency generation
>> portion of commit fe802d92bbe40d68e3ce61e1f30de1f0db531224
>> The way it is structured, adding tests would in essence be just an indirect
>> test for the GenerateAdjacency function. Which is why the aforementioned commit
>> it was based off does not include such tests, either.
> Yes, I know, but that is an implementation detail. Native might not do
> the same and in any case the tests should not care about what the
> implementation does or doesn't do.

Except for the observable behavior, of course...

More information about the wine-devel mailing list