[PATCH v3] ucrtbase: Implement some printf functions

Martin Storsjö martin at martin.st
Tue Oct 27 14:43:28 CDT 2015


On Tue, 27 Oct 2015, Martin Storsjö wrote:

> On Tue, 27 Oct 2015, Piotr Caban wrote:
>
>> Hi,
>> 
>> On 10/26/15 16:53, Martin Storsjo wrote:
>>> --- a/dlls/msvcrt/printf.h
>>> +++ b/dlls/msvcrt/printf.h
>>> +static int FUNC_NAME(puts_clbk_str_c99)(void *ctx, int len, const APICHAR 
>>> *str)
>> I think that it would be nicer if this function is added in wcs.c. Other 
>> callback functions are already added to files that uses them (e.g. file.c 
>> defines callbacks for functions printing to files).
>
> Ok, that makes sense - will do.

Actually, since this function is templated, it has to stay in some .h 
file in order to include it twice - otherwise I'd have to either duplicate 
the _a/_w implementations, or define it as a macro with the templating 
done via macro parameters. Which one of these seem most appealing to you?

// Martin


More information about the wine-devel mailing list