kernel32/tests: Simplify an ok() condition (PVS-Studio)

Michael Stefaniuc mstefani at redhat.com
Wed Oct 28 07:35:42 CDT 2015


On 10/28/2015 11:32 AM, Marvin wrote:
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=17766
> 
> Your paranoid android.
> 
> 
> === wxppro (32 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting
> comm.c:1553: test_AbortWaitCts timeout 500 handle 00000770
> comm.c:1520:  Changing CommMask on the fly for handle 00000770 after timeout 500
> 
> === w2003std (32 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting
> comm.c:1553: test_AbortWaitCts timeout 500 handle 00000760
> comm.c:1520:  Changing CommMask on the fly for handle 00000760 after timeout 500
> 
> === w2008s64 (32 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting
> comm.c:1553: test_AbortWaitCts timeout 500 handle 000000BC
> comm.c:1520:  Changing CommMask on the fly for handle 000000BC after timeout 500
> 
> === w7pro64 (32 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting
> comm.c:1553: test_AbortWaitCts timeout 500 handle 00000128
> comm.c:1520:  Changing CommMask on the fly for handle 00000128 after timeout 500
> 
> === wvistau64 (64 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting
> 
> === w7pro64 (64 bit comm) ===
> comm.c:861: Test failed: WaitCommEvent failed with a timeout
> comm.c:872: recovering after WAIT_TIMEOUT...
> comm.c:882: Test failed: WaitCommEvent error 0
> comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500)
> comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting

The errors are unrelated and sporadically show up in the testbot runs:
https://test.winehq.org/data/tests/kernel32:comm.html

And anyway this is a true no-op change as the compiler generates the
exact same object file when I remove the line wrapping.

bye
	michael



More information about the wine-devel mailing list