[PATCH] vbscript/tests: Show IActiveScriptSite OnScriptError is called on error

Jacek Caban jacek at codeweavers.com
Wed Oct 28 08:47:45 CDT 2015

Hi Alistair,

Sorry for late response.

On 10/27/15 09:56, Alistair Leslie-Hughes wrote:
>> How about using HRESULT here...
> Not sure how this would work without changing every test that throws
> an exception. I was trying to show that if S_OK is returned from
> OnScriptError then SCRIPT_E_REPORTED is the expected return.

I'm not sure why it wouldn't work. We currently return E_NOTIMPL and
it's fine. In your case, you could add onerror_hres, set it to E_NOTIMPL
and return it from OnScriptError. To test what you meant to test, you'd
change its value temporary to S_OK.

The reason I'd prefer it is that right now you test two things at the
time in a way that will complicate future development. When we implement
OnScriptError callback, we will hit GetExceptionInfo failure, which we
will have to work around. Obviously implementing GetExceptionInfo first
would be even better, but for that we'd need more tests, those wouldn't
be enough anyway.


More information about the wine-devel mailing list