[v3 signed 1/6] d3d9: improved d3d9_device_UpdateSurface

Riccardo Bortolato rikyz619 at gmail.com
Wed Oct 28 09:31:40 CDT 2015

I was actually wrong comparing stdout with stderr (I re-ran the tests
with a single output and identified the failing test better).

It was test_cube_wrap() but it was failing because of:

warn:d3d:wined3d_device_copy_sub_resource_region Resource types

The other errors related to UpdateSurface were most likely expected by
other tests, but since I wasn't running with the proper channels I
thought they were the ones causing failures.

I sent an updated couple of patches that seem to be working (checking
for volume textures instead of resource type matching).


2015-10-28 15:02 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 27 October 2015 at 19:01, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>> Sorry, gmail somehow sent this incomplete draft.. however, here's the
>> complete mail.
>> Why wined3d_device_copy_sub_resource_region() isn't implemented for
> No particular reason, it just wasn't needed yet.
>> But test_cube_wrap() (d3d9/visual.c) fails in UpdateSurface (if I got
>> debug right); the destination surface is smaller than the src rect
>> (I'm either getting the wrong sub index (e.g. the next mip) or what?),
>> this happens when the application (in this case the test) calls with
>> null src rect and dst point.
> What are the actual sizes and sub-resource indices you're getting? All
> the surfaces in test_cube_wrap() should be 128x128.

More information about the wine-devel mailing list