[PATCH 1/6] wineconsole: Add if check to determine whether a font attribute has changed (v2)

Dmitry Timoshkov dmitry at baikal.ru
Thu Oct 29 06:54:33 CDT 2015


Hugh McMaster <hugh.mcmaster at outlook.com> wrote:

> > > +    if (strcmpW(data->curcfg.face_name, cfg->face_name) || data->curcfg.cell_width != cfg->cell_width ||
> > > +        data->curcfg.cell_height != cfg->cell_height || data->curcfg.font_weight != cfg->font_weight)
> > >      {
> > >          data->fnSetFont(data, cfg->face_name, cfg->cell_height, cfg->font_weight);
> > >      }
> > 
> > Font names should be tested using a case insensitive check.
> 
> Do we use strcmpiW, lstrcmpiW or a function defined in wine/unicode.h for that?

Using any of them should be fine.

-- 
Dmitry.



More information about the wine-devel mailing list