[1/2] d3dx9_36: Implement D3DXGetShaderInputSemantics (try 2)
Alistair Leslie-Hughes
leslie_alistair at hotmail.com
Fri Sep 11 04:16:24 CDT 2015
On 11/09/15 03:30, Matteo Bruni wrote:
>
> Petty bickering aside, in general sending patches with git send-email
> makes so that I can easily inline my comments in the code. Sending
> your own patches yourself makes so that I'm replying to the actual
> patch author, which usually is the one who should update the patch
> according to my review. You're free to ignore those points but that
> doesn't help with my will to put the effort required to review the
> patches.
I investigate on howto use git send-email, it's not something that I've
used before.
>
> Anyway, this patch requires some cleanup (most obviously, using the
> appropriate defines like D3DSP_REGTYPE_SHIFT instead of all those
> magic numbers). Also I'm interested in seeing tests with pixel
> shaders, especially shader model 1 and 2 pixel shaders.
>
Thanks for the feedback. I'll correct these issues and resend once I'm
happy with them.
Best Regards
Alistair Leslie-Hughes
More information about the wine-devel
mailing list