wined3d public api cleanup

Riccardo Bortolato rikyz619 at gmail.com
Fri Sep 11 12:28:49 CDT 2015


My issue was with surface_check_block_align (used by tons of
functions) but I guess I'll (temporary) convert back to RECT and then
finally implement a wined3d_texture_check_block_align(tex, sub_idx,
box ..).

Ciao,
Riccardo

2015-09-11 19:24 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
> On 11 September 2015 at 18:34, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>>> Just pass a wined3d_box structure insead of a void pointer. (And
>>> passing a wined3d_box structure to wined3d_surface_map() should
>>> probably be a preparation patch for that.)
>>
>> I kept the RECT * because I get 24 hits in wined3d_private.h, it felt
>> like the change was too big and needed better thinking but I can
>> reverse the decision and pass around a wined3d_box * instead.
>>
> We'll probably want to consistently use wined3d_box at some point, but
> just changing wined3d_surface_map() shouldn't be too hard. We'd
> probably like a debug function along the lines of wine_dbgstr_rect()
> for boxes, but we don't currently have that for wined3d_volume_map()
> either.



More information about the wine-devel mailing list