wined3d public api cleanup

Riccardo Bortolato rikyz619 at gmail.com
Mon Sep 14 04:12:08 CDT 2015


Hi Henri,

> In patch 3/6 the decision to use wined3d_volume_map() or
> wined3d_surface_map() should probably go through wined3d_texture_ops.

About this one, what did you have in mind? an intermediate function
that casts the correct type from a resource and calls the proper
mapping function?

Ciao,
Riccardo

2015-09-11 19:38 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
> On 11 September 2015 at 19:28, Riccardo Bortolato <rikyz619 at gmail.com> wrote:
>> My issue was with surface_check_block_align (used by tons of
>> functions) but I guess I'll (temporary) convert back to RECT and then
>> finally implement a wined3d_texture_check_block_align(tex, sub_idx,
>> box ..).
>>
> I'm not sure we'll ever need that to be generic, just renaming the
> existing one to something like surface_check_block_align_rect() and
> then introducing a new surface_check_block_align() that takes a box
> should work. The rect variant should then eventually just go away.



More information about the wine-devel mailing list