[2/2] winhttp: Add custom implementation of IWinHttpRequest::Invoke(DISPID_HTTPREQUEST_OPTION).

Dmitry Timoshkov dmitry at baikal.ru
Tue Sep 15 06:39:11 CDT 2015


Hi Jacek,

Jacek Caban <jacek at codeweavers.com> wrote:

> > Even if you suspect that there might be some
> > problem with the typelib or the way oleaut32 interprets it, I'd suggest
> > to accept my patch since currently it's the only way to make Invoke in
> > winhttp work (and as my tests show probably even under Windows), that
> > shouldn't prevent you from investigating other problems if you still
> > plan to. What's your opinion on this?
> 
> My personal opinion is that I don't like the patch. If it was me working
> on this, I'd check if widl fixes would cover the need of your real
> application (which is easy to test even without actually fixing widl)
> and if it does, I'd concentrate on that. It would probably fix more bugs
> than just one specific winhttp function.

I have tested that already (and mentioned in my previous explanations
https://www.winehq.org/pipermail/wine-devel/2015-September/109076.html):
fixing widl wouldn't fix neither the test cases nor make the application
that I have here work.

> However, in terms of your patch correctness, I believe it is correct, so
> I think it is acceptable.

Thanks.

-- 
Dmitry.



More information about the wine-devel mailing list